Fix JdbcUserCredentialRepository Save #16621
Merged
+60
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
jzheaux
requested changes
Feb 24, 2025
.../java/org/springframework/security/web/webauthn/management/JdbcUserCredentialRepository.java
Outdated
Show resolved
Hide resolved
jzheaux
added
in: web
|
Also, will you please rebase to |
|
Hi @jzheaux . Thanks for your feedback. This component was introduced in current version, so it is not in |
franticticktick
force-pushed
the
gh-16620
branch
from
2f41603 to
af56c22
Compare
jzheaux
requested changes
Feb 27, 2025
There was a problem hiding this comment.
Thanks, @franticticktick! I've left a question for you inline.
.../java/org/springframework/security/web/webauthn/management/JdbcUserCredentialRepository.java
Outdated
Show resolved
Hide resolved
|
Thanks, @franticticktick! Can you squash your commits please? Then I think we're ready to merge. |
Closes spring-projectsgh-16620 Signed-off-by: Max Batischev <[email protected]>
franticticktick
force-pushed
the
gh-16620
branch
from
293883e to
e28b9bd
Compare
|
@jzheaux sory please, i usually don't miss things like that. |
jzheaux
approved these changes
Mar 7, 2025
|
Thanks, @franticticktick! This is now merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-16620